Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4695 State that the scope of a SetUpFixture is limited to an assembly #929

Conversation

maettu-this
Copy link
Contributor

@maettu-this
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Member

@SeanKilleen SeanKilleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this as long as @OsirisTerje agrees with the content. 👍

Thanks for the contribution!

Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maettu-this
Copy link
Contributor Author

I guess I need somebody's DevOps expertise to get the dofx build issue fixed. Doesn't seem related to my changes.

@SeanKilleen
Copy link
Member

@maettu-this no worries, that's not your fault. There's a piece that creates a netlify preview. That broke but it has nothing to do with your PR. Merging this. Thanks again!

@SeanKilleen SeanKilleen merged commit 69596e2 into nunit:master Apr 23, 2024
6 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
Co-authored-by: maettu-this <24897735+maettu-this@users.noreply.github.com> 69596e2
@maettu-this maettu-this deleted the 4695_State-that-the-scope-of-a-SetUpFixture-is-limited-to-an-assembly branch April 24, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants