Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK 3.20 :: Optimised headerbar and titlebar size #614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

megax
Copy link
Contributor

@megax megax commented Oct 24, 2016

Gnome-shell:
image

Cinnamon:
image

Ubuntu:
image

@megax
Copy link
Contributor Author

megax commented Oct 24, 2016

@khurshid-alam Minimal optimization. So look better. Right at lower resolutions. :)

@khurshid-alam
Copy link
Contributor

Is it?

@megax
Copy link
Contributor Author

megax commented Oct 24, 2016

@khurshid-alam This? :) Maybe it is strange for the first time. I think we should have take a picture of the current state as well. If you compare, you can see that between the button's and headerbar;titlebar's edges is a large amount of space, which is strange.
I didn't repair long time ago, because the code wasn't assemled and tested. Now we could do it, I tested and have time to refine it. It is just an optical tuning and looks better on smaller screen by the way. It gives it a kind of old numix style when it was such thin. I didn't want to open a new Issue for it. Retrospectively I am sorry for that!
Please test it, I've already done it and I couldn't find any regressions. (Only the character size, but it is depend on the settings as before. The theme can't help on it.. It is depend on the user too.)

@khurshid-alam
Copy link
Contributor

Padding is too less here. Only thing it does that it puts switches and buttons inline.

....you compare, you can see that between the button's and headerbar;titlebar's edges is a large amount of space, which is strange.

There are other areas which are proportionally large (nautilus sidebar selection etc) which needs to be fixed first.

I put this on hold.

@megax
Copy link
Contributor Author

megax commented Oct 24, 2016

Okay :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants