This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Fixing nyc_taxi.csv #3748
Open
Fixing nyc_taxi.csv #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jlee124, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zuhaagha and @rhyolight to be potential reviewers. |
| _INPUT_MIN = 8 | ||
|
|
||
| # maximum metric value of nyc_taxi.csv | ||
| # maximum metric value of nycTaxi.csv |
There was a problem hiding this comment.
@rhyolight -- but weren't we supposed to be standardizing on using underscores in file names (versus camelcase)?
There was a problem hiding this comment.
That standard was only for python source file names. I don't think we have a standard for data files. I'm happy as long as it works.
|
@jlee124 Thanks! please remember to sign our contributor license before we can merge this. |
rhyolight
approved these changes
Jul 24, 2017
|
@jlee124 We still need you to sign our contributor license. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked on issue #3747 to update nyc_taxi.csv to nycTaxi.csv in nyctaxi_anomaly.py and changed file name in ./src/nupic/datafiles/extra/nycTaxi/nyc_taxi.csv to nycTaxi.csv.