Deprecate user plainPassword in favor of using UserManipulator #2361
core23continuous-integration.yml
on: pull_request
run
/
Generate test matrix
4s
Matrix: run / Code Coverage
Matrix: run / Coding Standards
Matrix: run / Lint composer.json
Matrix: run / Lint symfony container
Matrix: run / Mutation Tests
Matrix: run / Static Code Analysis
Matrix: run / Lint twig files
Matrix: run / Lint XLIFF files
Matrix: run / Lint YML files
Matrix: run / tests
Annotations
4 errors and 27 warnings
|
run / Static Code Analysis (8.3)
<error>Child process error</error> (exit code 255): PHP Fatal error: Declaration of PHPStan\Doctrine\Mapping\ClassMetadataFactory::newClassMetadataInstance($className) must be compatible with Doctrine\ORM\Mapping\ClassMetadataFactory::newClassMetadataInstance(string $className): Doctrine\ORM\Mapping\ClassMetadata in /home/runner/work/NucleosUserBundle/NucleosUserBundle/vendor-bin/tools/vendor/phpstan/phpstan-doctrine/src/Doctrine/Mapping/ClassMetadataFactory.php on line 62
Fatal error: Declaration of PHPStan\Doctrine\Mapping\ClassMetadataFactory::newClassMetadataInstance($className) must be compatible with Doctrine\ORM\Mapping\ClassMetadataFactory::newClassMetadataInstance(string $className): Doctrine\ORM\Mapping\ClassMetadata in /home/runner/work/NucleosUserBundle/NucleosUserBundle/vendor-bin/tools/vendor/phpstan/phpstan-doctrine/src/Doctrine/Mapping/ClassMetadataFactory.php on line 62
|
|
run / Static Code Analysis (8.3)
<error>Child process error</error> (exit code 255): PHP Fatal error: Declaration of PHPStan\Doctrine\Mapping\ClassMetadataFactory::newClassMetadataInstance($className) must be compatible with Doctrine\ORM\Mapping\ClassMetadataFactory::newClassMetadataInstance(string $className): Doctrine\ORM\Mapping\ClassMetadata in /home/runner/work/NucleosUserBundle/NucleosUserBundle/vendor-bin/tools/vendor/phpstan/phpstan-doctrine/src/Doctrine/Mapping/ClassMetadataFactory.php on line 62
Fatal error: Declaration of PHPStan\Doctrine\Mapping\ClassMetadataFactory::newClassMetadataInstance($className) must be compatible with Doctrine\ORM\Mapping\ClassMetadataFactory::newClassMetadataInstance(string $className): Doctrine\ORM\Mapping\ClassMetadata in /home/runner/work/NucleosUserBundle/NucleosUserBundle/vendor-bin/tools/vendor/phpstan/phpstan-doctrine/src/Doctrine/Mapping/ClassMetadataFactory.php on line 62
|
|
run / Static Code Analysis (8.3)
<error>Child process error</error> (exit code 255): PHP Fatal error: Declaration of PHPStan\Doctrine\Mapping\ClassMetadataFactory::newClassMetadataInstance($className) must be compatible with Doctrine\ORM\Mapping\ClassMetadataFactory::newClassMetadataInstance(string $className): Doctrine\ORM\Mapping\ClassMetadata in /home/runner/work/NucleosUserBundle/NucleosUserBundle/vendor-bin/tools/vendor/phpstan/phpstan-doctrine/src/Doctrine/Mapping/ClassMetadataFactory.php on line 62
Fatal error: Declaration of PHPStan\Doctrine\Mapping\ClassMetadataFactory::newClassMetadataInstance($className) must be compatible with Doctrine\ORM\Mapping\ClassMetadataFactory::newClassMetadataInstance(string $className): Doctrine\ORM\Mapping\ClassMetadata in /home/runner/work/NucleosUserBundle/NucleosUserBundle/vendor-bin/tools/vendor/phpstan/phpstan-doctrine/src/Doctrine/Mapping/ClassMetadataFactory.php on line 62
|
|
run / Static Code Analysis (8.3)
Process completed with exit code 2.
|
|
run / Lint symfony container (8.3)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Lint composer.json (8.3)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Lint YML files (8.3)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Lint twig files (8.3)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Lint XLIFF files (8.3)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Coding Standards (8.3)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Static Code Analysis (8.3)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Test: PHP 8.2, Symfony 6.4, lowest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Test: PHP 8.3, Symfony 6.4, highest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Test: PHP 8.3, Symfony 7.0, lowest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Code Coverage (8.3)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Test: PHP 8.2, Symfony 7.0, highest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Test: PHP 8.2, Symfony 7.0, lowest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Test: PHP 8.3, Symfony 6.4, lowest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Test: PHP 8.2, Symfony 6.4, highest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Test: PHP 8.3, Symfony 7.0, highest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Mutation Tests (8.3)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
run / Mutation Tests (8.3):
src/Action/LoginAction.php#L65
Escaped Mutant for Mutator "MethodCallRemoval":
--- Original
+++ New
@@ @@
public function __invoke(Request $request) : Response
{
$event = new GetResponseLoginEvent($request);
- $this->eventDispatcher->dispatch($event, NucleosUserEvents::SECURITY_LOGIN_INITIALIZE);
+
if (null !== $event->getResponse()) {
return $event->getResponse();
}
|
|
run / Mutation Tests (8.3):
src/Action/LoginAction.php#L72
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
if (null !== $event->getResponse()) {
return $event->getResponse();
}
- $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
+ $form = $this->formFactory->create(LoginFormType::class, null, ['method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.3):
src/Action/LoginAction.php#L76
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
if (null !== $event->getResponse()) {
return $event->getResponse();
}
- $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
+ $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, []);
return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.3):
src/Action/LoginAction.php#L83
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
return $event->getResponse();
}
$form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
- return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
+ return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' > $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.3):
src/Action/LoginAction.php#L84
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
return $event->getResponse();
}
$form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
- return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
+ return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' > $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.3):
src/Action/LoginAction.php#L85
Escaped Mutant for Mutator "ArrayItem":
--- Original
+++ New
@@ @@
return $event->getResponse();
}
$form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']);
- return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' => $this->csrfTokenManager->getToken('authenticate')]));
+ return new Response($this->twig->render('@NucleosUser/Security/login.html.twig', ['form' => $form->createView(), 'last_username' => $this->authenticationUtils->getLastUsername(), 'error' => $this->authenticationUtils->getLastAuthenticationError(), 'csrf_token' > $this->csrfTokenManager->getToken('authenticate')]));
}
}
|
|
run / Mutation Tests (8.3):
src/Action/RequestResetAction.php#L95
Escaped Mutant for Mutator "MethodCallRemoval":
--- Original
+++ New
@@ @@
public function __invoke(Request $request) : Response
{
$form = $this->createForm();
- $form->handleRequest($request);
+
if ($form->isSubmitted() && $form->isValid()) {
$response = $this->process($request);
$this->getFlashBag($request)?->add('success', $this->translator->trans('resetting.check_email', ['%tokenLifetime%' => ceil($this->retryTtl / 3600)], 'NucleosUserBundle'));
|
|
run / Mutation Tests (8.3):
src/Action/RequestResetAction.php#L97
Escaped Mutant for Mutator "LogicalAndSingleSubExprNegation":
--- Original
+++ New
@@ @@
{
$form = $this->createForm();
$form->handleRequest($request);
- if ($form->isSubmitted() && $form->isValid()) {
+ if ($form->isSubmitted() && !$form->isValid()) {
$response = $this->process($request);
$this->getFlashBag($request)?->add('success', $this->translator->trans('resetting.check_email', ['%tokenLifetime%' => ceil($this->retryTtl / 3600)], 'NucleosUserBundle'));
if (null !== $response) {
|
|
run / Mutation Tests (8.3):
src/Action/RequestResetAction.php#L198
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
}
private function createForm() : FormInterface
{
- return $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_request'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']);
+ return $this->formFactory->create(RequestPasswordFormType::class, null, ['method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']);
}
}
|
|
run / Mutation Tests (8.3):
src/Action/RequestResetAction.php#L202
Escaped Mutant for Mutator "ArrayItemRemoval":
--- Original
+++ New
@@ @@
}
private function createForm() : FormInterface
{
- return $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_request'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'resetting.request.submit']);
+ return $this->formFactory->create(RequestPasswordFormType::class, null, ['action' => $this->router->generate('nucleos_user_resetting_request'), 'method' => 'POST'])->add('save', SubmitType::class, []);
}
}
|