Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protected BaseResult() method to CallInfo. #641

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add protected BaseResult() method to CallInfo. #641

wants to merge 2 commits into from

Commits on Mar 28, 2021

  1. Add protected BaseResult() method to CallInfo. 

    Create CallInfo<T> to calls that return results and expose `BaseResult`.
This gets messy to push the generic all the way through the code, so am
just using a cast in `Returns` extensions to handle this. This should be
safe as if we are in `Returns<T>` then the return value should be safe to
cast to a `T`.

Based off discussion here:
nsubstitute#622 (comment)
    @dtchepak
    dtchepak committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    7409f4e View commit details
    Browse the repository at this point in the history

  2. Extract ICallInfo interfaces (nsubstitute#641) 

    Apply review comments.
    @dtchepak
    dtchepak committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    b89b34e View commit details
    Browse the repository at this point in the history