Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-219 - handling protected internal constructors when analyzing NS2001 diagnostic #221

Merged
merged 1 commit into from May 3, 2024
Merged

GH-219 - handling protected internal constructors when analyzing NS2001 diagnostic #221

merged 1 commit into from May 3, 2024

Conversation

tpodolak
Copy link
Member

Closes #219

@coveralls
Copy link

Pull Request Test Coverage Report for Build 550

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 97.117%
Files with Coverage Reduction New Missed Lines %
C/projects/nsubstitute-analyzers/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/SubstituteConstructorAnalysis.cs 1 93.88%
Totals Coverage Status
Change from base Build 549: 0.002%
Covered Lines: 2661
Relevant Lines: 2740
💛 - Coveralls

@tpodolak tpodolak merged commit a4d589a into dev May 3, 2024
1 check passed
@tpodolak tpodolak deleted the GH-219-ns2002-false-positive-protected-internal branch May 3, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtchepak dtchepak dtchepak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NS2001: False positive for class with protected internal constructor
3 participants
@tpodolak @coveralls @dtchepak