nsqd: support POST auth #1487
Merged
nsqd: support POST auth #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready for review |
|
I am curious for folks feedback on if we should make |
mreiferson
requested changes
Apr 28, 2024
|
@mreiferson Updated per your feedback! Thanks! |
mreiferson
force-pushed
the
support_post_auth
branch
from
c3556fa
to
f162880
Compare
|
(I did some minor function renaming and squashed/renamed the commit for merge...) |
Adds simple config option and flag to allow for auth to occur via POST request in addition to GET. Rationale: Errors from net/http requests are bubbled to nsqd when there is an error during authentication, such as if the nsq authentication server is unavailable. These errors include the full path, including any GET parameter, thus causing the authentication secret to be logged. This does not occur by default for the POST body thus helping protect secrets in transit between nsqd and the authentication server.
mreiferson
force-pushed
the
support_post_auth
branch
from
f162880
to
0db445c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for POST based authentication in addition to GET based authentication.
As described in #1486, the default behavior of nsqd to to propagate upward any errors from
net/httpclients which leads to Secret's leakage if the authentication server is unavailble.