-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): fix failing unit test #23392
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e4aaba7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
f87419f
to
c7a0877
Compare
c7a0877
to
e4aaba7
Compare
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> Getting inputs sometimes may cause Nx to panic ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Getting inputs will return an error rather than panic which should come along with stack traces. Also, a test which sometimes.. triggered the panic... is maybe fixed? ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 09fd1bb)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> Getting inputs sometimes may cause Nx to panic ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Getting inputs will return an error rather than panic which should come along with stack traces. Also, a test which sometimes.. triggered the panic... is maybe fixed? ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Getting inputs sometimes may cause Nx to panic
Expected Behavior
Getting inputs will return an error rather than panic which should come along with stack traces.
Also, a test which sometimes.. triggered the panic... is maybe fixed?
Related Issue(s)
Fixes #