Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): profiling #23253

Closed
wants to merge 26 commits into from
Closed

chore(repo): profiling #23253

wants to merge 26 commits into from

Conversation

JamesHenry
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 16, 2024 9:22am

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies the same change as in packages/js/src/plugins/jest/start-local-registry.ts so that it is immediately available for use.

The patch (and reference to it in package.json) can be removed once a version of Nx is released that contains this PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an easy diff to read, probably better to review the final state of the file in isolation

@JamesHenry
Copy link
Collaborator Author

Closing in favour of #23429 to have a clean history and be more focused on what this ended up becoming

@JamesHenry JamesHenry closed this May 16, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant