-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(misc): make generated ci workflow work without nx-cloud (#23199)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> `ci-workflow` generators error if Nx Cloud has not been enabled. With the new Github onboarding flow, there is a chicken or the egg problem. The Github onboarding flow creates a PR but we don't have a pipeline to run against it. To create the pipeline, Nx Cloud has to be enabled... which... creates a lackluster PR. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `ci-workflow` generators do not error if Nx Cloud has not been enabled. This way, the `ci-workflow` generator will be able to create a workflow, which the PR made by Nx Cloud's Github onboarding flow will be run against. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
- Loading branch information
1 parent
f13dcce
commit 41d21ab
Showing
11 changed files
with
99 additions
and
132 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.