Change default value for MQTT buffers max size #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
CC @simensrostad please have a look. |
rlubos
approved these changes
May 19, 2020
jtguggedal
approved these changes
May 22, 2020
|
@xnaveira could you please sign the CLA? |
I thought I had already done it, it is done now @carlescufi ! |
rlubos
requested changes
Jun 23, 2020
There was a problem hiding this comment.
Please update the commit message to follow https://docs.zephyrproject.org/latest/contribute/index.html#commit-guidelines, something like:
net: lib: aws_iot: Change default value for MQTT buffers max size
The current default value for AWS_IOT_MQTT_RX_TX_BUFFER_LEN and
AWS_IOT_MQTT_PAYLOAD_BUFFER_LEN which is 256 makes subscription
to shadow topics fail silently. Increasing to 1000 makes possible
to receive shadow updates.
Signed-off-by: Xavier Naveira <xnaveira@gmail.com>
The current default value for AWS_IOT_MQTT_RX_TX_BUFFER_LEN and AWS_IOT_MQTT_PAYLOAD_BUFFER_LEN which is 256 makes subscription to shadow topics fail silently. Increasing to 1000 makes possible to receive shadow updates. Signed-off-by: Xavier Naveira <xnaveira@gmail.com>
xnaveira
force-pushed
the
mqtt-buf-default-size
branch
from
76e0823
to
440ae9b
Compare
Done! |
rlubos
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default value for AWS_IOT_MQTT_RX_TX_BUFFER_LEN and AWS_IOT_MQTT_PAYLOAD_BUFFER_LEN which is 256 makes subscription to shadow topics fail silently. Increasing to 1000 makes possible to receive shadow updates.
Similar issue: copercini/esp8266-aws_iot#7