Feature: Retry policy with exponential delay #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozzlegear
force-pushed
the
exponential-retry-policy
branch
from
daf1ca0
to
48e06d8
Compare
nozzlegear
force-pushed
the
exponential-retry-policy
branch
from
48e06d8
to
510aa89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull adds a retry policy with an exponential delay in between failed requests. It's very similar to the default
RetryExecutionPolicy, except that each failure adds a(2 ^ currentTry - 1) * delayInMillisecondsbefore it tries again.The policy makes not attempt to be smart, it does not care about Shopify rate limits or other requests made by the same shop. It's just a "dumb" policy that will exponentially delay itself until a request goes through or a maximum number of tries have been attempted.
Just missing the last few tests before merging.