Merge pull request #1021 from clement911/master

Revert "Using a fifo semaphore to ensure that requests are granted ac…
nozzlegear · Feb 19, 2024 · 924fbab · 924fbab
2 parents c693018 + f5d1a9c
commit 924fbab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 40 deletions.
diff --git a/ShopifySharp/Infrastructure/Policies/LeakyBucketPolicy/FifoSemaphore.cs b/ShopifySharp/Infrastructure/Policies/LeakyBucketPolicy/FifoSemaphore.cs
diff --git a/ShopifySharp/Infrastructure/Policies/LeakyBucketPolicy/LeakyBucket.cs b/ShopifySharp/Infrastructure/Policies/LeakyBucketPolicy/LeakyBucket.cs
@@ -9,7 +9,7 @@ internal class LeakyBucket
         private class Request
         {
             public int cost;
-            public FifoSemaphore fifoSemaphore = new FifoSemaphore(0, 1);
+            public SemaphoreSlim semaphore = new SemaphoreSlim(0, 1);
             public CancellationToken cancelToken;
 
             public Request(int cost, CancellationToken cancelToken)
@@ -109,7 +109,7 @@ public async Task WaitForAvailableAsync(int requestCost, CancellationToken cance
                 if (_waitingRequests.Count == 1)
                     ScheduleTryGrantNextPendingRequest(r);
             }
-            await r.fifoSemaphore.WaitAsync(cancellationToken);
+            await r.semaphore.WaitAsync(cancellationToken);
         }
 
         private void ScheduleTryGrantNextPendingRequest(Request r)
@@ -132,7 +132,7 @@ private void TryGrantNextPendingRequest()
                     var r = _waitingRequests.Dequeue();
                     if (!r.cancelToken.IsCancellationRequested)
                     {
-                        r.fifoSemaphore.Release();
+                        r.semaphore.Release();
                         ConsumeAvailable(r);
                     }
                 }