New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New design system pkg] Update web
imports to point to new Panda
#5546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antonjoel82
force-pushed
the
ds-web-imports
branch
2 times, most recently
from
May 13, 2024 16:35
8b158ff
to
91af393
Compare
antonjoel82
changed the title
[New design system pkg] Update imports
[New design system pkg] Update May 13, 2024
web
imports to point to new Panda
antonjoel82
requested review from
scopsy and
AliaksandrRyzhou
and removed request for
a team
May 17, 2024 00:47
SokratisVidros
approved these changes
May 17, 2024
apps/web/package.json
Outdated
@@ -169,6 +171,7 @@ | |||
"react-app-rewired": "^2.2.1", | |||
"react-error-overlay": "6.0.11", | |||
"react-scripts": "^5.0.1", | |||
"sinon": "9.2.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this addition required? Note that Cypress is going away later today.
antonjoel82
force-pushed
the
ds-web-imports
branch
from
May 17, 2024 17:19
91af393
to
9dae030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
To avoid noise in the main PR (#5467), we handle updating all the existing local
styled-system
references inweb
to the design-system