Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New design system pkg] Update web imports to point to new Panda #5546

Merged
merged 3 commits into from May 17, 2024

Conversation

antonjoel82
Copy link
Contributor

@antonjoel82 antonjoel82 commented May 10, 2024

What changed? Why was the change needed?

To avoid noise in the main PR (#5467), we handle updating all the existing local styled-system references in web to the design-system

Copy link

netlify bot commented May 10, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 91af393
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6642414e2c73cc0008056b17
😎 Deploy Preview https://deploy-preview-5546--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 10, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit d44cdf2
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/664791d51a2f70000805787f
😎 Deploy Preview https://deploy-preview-5546--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antonjoel82 antonjoel82 force-pushed the ds-web-imports branch 2 times, most recently from 8b158ff to 91af393 Compare May 13, 2024 16:35
@antonjoel82 antonjoel82 changed the title Ds web imports [New design system pkg] Update imports May 13, 2024
@antonjoel82 antonjoel82 changed the title [New design system pkg] Update imports [New design system pkg] Update web imports to point to new Panda May 13, 2024
@antonjoel82 antonjoel82 changed the base branch from next to ds-new-pkg May 15, 2024 00:05
@antonjoel82 antonjoel82 marked this pull request as ready for review May 17, 2024 00:47
@antonjoel82 antonjoel82 requested review from a team as code owners May 17, 2024 00:47
@antonjoel82 antonjoel82 requested review from scopsy and AliaksandrRyzhou and removed request for a team May 17, 2024 00:47
@@ -169,6 +171,7 @@
"react-app-rewired": "^2.2.1",
"react-error-overlay": "6.0.11",
"react-scripts": "^5.0.1",
"sinon": "9.2.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this addition required? Note that Cypress is going away later today.

@antonjoel82 antonjoel82 merged commit 296d61f into ds-new-pkg May 17, 2024
4 checks passed
@antonjoel82 antonjoel82 deleted the ds-web-imports branch May 17, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants