feat: add ability to set channels during trigger #5541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
commented
May 10, 2024
| if ( | ||
| subscriber && | ||
| !subscriberNeedUpdate(subscriber, subscriberPayload) && | ||
| !subscriberPayload.channels |
There was a problem hiding this comment.
I don't entirely like this, but this is for now until we have a better diff logic happening here
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
approved these changes
May 10, 2024
| </envs> | ||
| <ui /> | ||
| <extra-mocha-options>--timeout 30000 --require ts-node/register --exit --file e2e/setup.ts</extra-mocha-options> | ||
| <extra-mocha-options>--require ts-node/register --exit --file e2e/setup.ts</extra-mocha-options> |
There was a problem hiding this comment.
i wonder what is the default timeout, it does not exist it would be better to have it defined here
SokratisVidros
pushed a commit
that referenced
this pull request
May 13, 2024
* feat: add ability to set channels during trigger * fix: tests * fix: remove duplicate check for subscriber needs update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
We already support creating a subscriber during trigger, this change allows creating it with the channels object for push and chat channels similarly to how ew allow doing that with email and phone today.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer