New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ntfy provider #5341
Open
sandsower
wants to merge
13
commits into
novuhq:next
Choose a base branch
from
sandsower:ntfy-provider
base: next
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ntfy provider #5341
+385
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the ntfy push provider to Novu, including support for base URL for self-hosting options
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
github-actions
bot
added
@novu/api
@novu/web
@novu/dal
@novu/shared
providers
docker
community
labels
Mar 29, 2024
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scopsy
requested changes
Apr 22, 2024
BiswaViraj
requested changes
Apr 22, 2024
packages/application-generic/src/factories/push/handlers/ntfy.handler.ts
Outdated
Show resolved
Hide resolved
…handler.ts Co-authored-by: Biswajeet Das <biswajeetdas18@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Adds ntfy support as a push provider
Why was this change needed?
Closes #4185
Other information (Screenshots)
Continues work started by @ayushdiitr way back in October, this fixes the configuration and finishes up the setup