Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency nodemailer to v6.9.9 [security] - autoclosed #5236

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 25, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
nodemailer (source) 6.9.1 -> 6.9.9 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

GHSA-9h6g-pr28-7cqp

Summary

A ReDoS vulnerability occurs when nodemailer tries to parse img files with the parameter attachDataUrls set, causing the stuck of event loop.
Another flaw was found when nodemailer tries to parse an attachments with a embedded file, causing the stuck of event loop.

Details

Regex: /^data:((?:[^;];)(?:[^,])),(.)$/

Path: compile -> getAttachments -> _processDataUrl

Regex: /(<img\b[^>]* src\s*=[\s"']*)(data:([^;]+);[^"'>\s]+)/

Path: _convertDataImages

PoC

https://gist.github.com/francoatmega/890dd5053375333e40c6fdbcc8c58df6
https://gist.github.com/francoatmega/9aab042b0b24968d7b7039818e8b2698

Impact

ReDoS causes the event loop to stuck a specially crafted evil email can cause this problem.


Release Notes

nodemailer/nodemailer (nodemailer)

v6.9.9

Compare Source

Bug Fixes
  • security: Fix issues described in GHSA-9h6g-pr28-7cqp. Do not use eternal matching pattern if only a few occurences are expected (dd8f5e8)
  • tests: Use native node test runner, added code coverage support, removed grunt (#​1604) (be45c1b)

v6.9.8

Compare Source

Bug Fixes
  • punycode: do not use native punycode module (b4d0e0c)

v6.9.7

Compare Source

Bug Fixes
  • customAuth: Do not require user and pass to be set for custom authentication schemes (fixes #​1584) (41d482c)

v6.9.6

Compare Source

Bug Fixes
  • inline: Use 'inline' as the default Content Dispostion value for embedded images (db32c93)
  • tests: Removed Node v12 from test matrix as it is not compatible with the test framework anymore (7fe0a60)

v6.9.5

Compare Source

Bug Fixes
  • license: Updated license year (da4744e)

v6.9.4

Compare Source

  • Renamed SendinBlue to Brevo

v6.9.3

Compare Source

  • Specified license identifier (was defined as MIT, actual value MIT-0)
  • If SMTP server disconnects with a message, process it and include as part of the response error

v6.9.2

Compare Source

  • Fix uncaught exception on invalid attachment content payload

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

netlify bot commented Feb 25, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit b034303
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/664b18d11a6a0f0008b7fd39
😎 Deploy Preview https://deploy-preview-5236--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch from 23781e1 to 39a90a9 Compare February 26, 2024 13:24
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 6 times, most recently from 7941ce2 to a4e5659 Compare March 13, 2024 11:39
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 2 times, most recently from 48255e7 to 436c0be Compare March 16, 2024 19:59
@github-actions github-actions bot added the stale Pull Request that needs to be reviewed label Mar 30, 2024
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch from 436c0be to 73c74ea Compare April 3, 2024 20:56
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit b034303
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/664b18d1d29b120008df5a73
😎 Deploy Preview https://deploy-preview-5236--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot removed the stale Pull Request that needs to be reviewed label Apr 3, 2024
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 2 times, most recently from 78e635e to e106194 Compare April 7, 2024 15:11
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch 2 times, most recently from fa5ff51 to e7984e1 Compare May 20, 2024 09:07
@renovate renovate bot force-pushed the renovate/npm-nodemailer-vulnerability branch from e7984e1 to b034303 Compare May 20, 2024 09:33
@renovate renovate bot changed the title fix(deps): update dependency nodemailer to v6.9.9 [security] fix(deps): update dependency nodemailer to v6.9.9 [security] - autoclosed May 20, 2024
@renovate renovate bot closed this May 20, 2024
@renovate renovate bot deleted the renovate/npm-nodemailer-vulnerability branch May 20, 2024 11:15
Copy link

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Your PR title is: fix(deps): update dependency nodemailer to v6.9.9 [security] - autoclosed
It should be something like: feat(scope): Add fancy new feature

Details:

Unknown scope "deps" found in pull request title "fix(deps): update dependency nodemailer to v6.9.9 [security] - autoclosed". Scope must match one of: api, inbound-mail, web, webhook, widget, worker, ws, ee-auth, ee-billing, ee-billing-web, ee-echo-api, ee-echo-web, ee-echo-worker, ee-dal, ee-shared-services, ee-translation, ee-translation-web, automation, dal, design-system, embed, novui, shared, shared-web, testing, application-generic, novu-labs, client, headless, nest, node, notification-center, angular-workspace, notification-center-angular, notification-center-vue, providers, echo, stateless.

@scopsy
Copy link
Contributor

scopsy commented May 20, 2024

cc @rifont

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant