Added django authentication plugins and the option to set the target inside an auth plugin #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the file django_auth_plugins.py, in which there are two plugins that integrate django authentication with websockify.
The plugin "SessionIdAuth" works with the original websockify. What it does: it grants access to the target only to the users authenticated in a django web app.
The plugin "SessionIdAuthAndHostPort" works only with my modified version of websockify. What it does: it sets the target based on the authenticated user. To make this plugin work I modified websocketproxy.py in order do let the authentication plugin choose the target. To enable this feature, I added the --auth-host-port option.