New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unescaped arguments in websockify command #1741
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your fix!
I'm afraid it isn't entirely correct, though. Please have a look at the comment.
utils/novnc_proxy
Outdated
--record) RECORD_ARG="--record ${OPTARG}"; shift ;; | ||
--syslog) SYSLOG_ARG="--syslog ${OPTARG}"; shift ;; | ||
--record) RECORD_ARG='--record "${OPTARG}"'; shift ;; | ||
--syslog) SYSLOG_ARG='--syslog "${OPTARG}"'; shift ;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid '
disables variable expansion, so this won't work.
@tutacat do you think you will get a chance to fix this? |
This looks better, but unfortunately, it still doesn't work. It is still splitting the words for the record, syslog and auth arguments. |
When passing a path with spaces to websockify, it is incorrectly read as multiple arguments, because the args weren't enclosed in quotes.