Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add queue-fix for queue creation/repair #267

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

mbhangui
Copy link
Contributor

@mbhangui mbhangui commented Feb 6, 2024

New program queue-fix which can create or repair a queue directory passed to it on the command line

queue-fix.c Fixed Show fixed Hide fixed
queue-fix.c Fixed Show fixed Hide fixed
queue-fix.c Fixed Show fixed Hide fixed
queue-fix.c Fixed Show fixed Hide fixed
queue-fix.c Fixed Show fixed Hide fixed
queue-fix.c Fixed Show fixed Hide fixed
queue-fix.c Fixed Show fixed Hide fixed
queue-fix.c Fixed Show fixed Hide fixed
queue-fix.c Fixed Show fixed Hide fixed
queue-fix.c Fixed Show fixed Hide fixed
@schmonz schmonz added this to the 2.0 milestone Feb 6, 2024
@schmonz
Copy link
Member

schmonz commented Feb 6, 2024

Last time we thought about this together, which admittedly was quite some time ago, we thought a sysadmin-facing queue fix/create tool would belong in 2.0 (or maybe slightly before that, to aid in the transition of the queue format).

We do usually like to borrow well-loved code that qmail users have been relying on, but I'm not sure we've put in enough consideration yet for what we'll need our own queue-maintenance tool to be able to do and how best to have it do that.

Should we be considering this PR with urgency for 1.09? as a helpful stopgap soonish?

I like queue-fix and appreciate what you've done with it, just trying to understand where we want this to fit in our plans.

@mbhangui
Copy link
Contributor Author

mbhangui commented Feb 6, 2024

We do usually like to borrow well-loved code that qmail users have been relying on, but I'm not sure we've put in enough consideration yet for what we'll need our own queue-maintenance tool to be able to do and how best to have it do that.

The most important feature of queue-fix isn't the ability to create a queue during installation, but repair a damaged queue after a filesystem corruption. This situation will not likely happen with normal user. But very likely to happen on a mail server with heavy traffic where the queue filesystem is the most heavily used. Hard reboot of such a server has the potential of damaging the filesystem on which /var/qmail/queue lies. When this happens it is sometime impossible to queue new messages. The qmail-send logs too get filled with errors. queue-fix is a quick way to fix the queue if the server doesn't have the source code.

Should we be considering this PR with urgency for 1.09? as a helpful stopgap soonish?

I feel there is no urgency. We have instpackage queue-only option to create the queue. Most notqmail users are adept at installing patches and can always get the queue-fix program from various sources. But having queue-fix is more of a long term strategy where there isn't a single tool missing in the notqmail arsenal that helps the end user fix issues.

@josuah
Copy link

josuah commented Feb 6, 2024

That sounds also a lot alike notqmail to try to integrate the features that are the most expected by their users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants