slightly simplify and clean up the qmail-send job helper functions #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerDakon
requested review from
leahneukirchen,
schmonz,
jlmuir,
mbhangui,
xenotrope and
josuah
mbhangui
approved these changes
Mar 28, 2021
DerDakon
force-pushed
the
Dakon-qsend-jobs
branch
from
3de0c01
to
9bb3571
Compare
|
pass_selprep needs adjustment for the new return value of job_avail ( Line 1004 in 9bb3571 |
|
My "Legacy Open Source Fridays" ensemble-programming session will be submitting a PR shortly (probably this Friday) to add tests around the existing behaviors of |
|
I would welcome that. Since I plan to make them |
DerDakon
force-pushed
the
Dakon-qsend-jobs
branch
from
9bb3571
to
c6aa444
Compare
DerDakon
force-pushed
the
Dakon-qsend-jobs
branch
from
c6aa444
to
ed143a9
Compare
DerDakon
force-pushed
the
Dakon-qsend-jobs
branch
from
ed143a9
to
9604513
Compare
leahneukirchen
approved these changes
Nov 15, 2022
job_avail() already knew which was the next available job slot. job_open() would scan for the same number again. In case there would be no job free by then it returned -1, which was never checked, but used as an array index.
DerDakon
force-pushed
the
Dakon-qsend-jobs
branch
from
9604513
to
d831e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.