style adjustment to dns.c, only the part that already changed #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josuah
requested review from
leahneukirchen,
schmonz,
jlmuir,
mbhangui,
DerDakon and
xenotrope
DerDakon
reviewed
Jan 26, 2021
|
ping? |
mbhangui
approved these changes
Aug 13, 2021
josuah
force-pushed
the
josuah-oversize-dns-style
branch
from
ae9071e
to
f993b32
Compare
|
pong! |
DerDakon
approved these changes
Sep 28, 2021
josuah
force-pushed
the
josuah-oversize-dns-style
branch
from
f993b32
to
7a84abc
Compare
josuah
added
enhancement
DerDakon
requested changes
May 10, 2022
josuah
force-pushed
the
josuah-oversize-dns-style
branch
3 times, most recently
from
c1e956c
to
ca77651
Compare
- no need for a struct around remote.buf anymore, convert to plain (char *), - check for failure (`if (!buf) ERR`) rather than success (`if (buf) ... else ERR` for consistency with surrounding code, - small style changes.
DerDakon
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (!buf) ERR) rather than success (if (buf) ... else ERRfor consistency with surrounding code,