Rework the make-* scripts for simpler toolchain #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerDakon
requested changes
Apr 11, 2020
DJB generate compilation tools by concatenating - warning header - a file with CC='' LD='' - make-<file>.sh with the echo 'things to add in <file>' The end compilation tool <file> gets gen generated by executing make-<file> which produces a short script with the commands to execute directly. The make-makelib script did not have the same treatment as the others, as AR and RANLIB was not configurable. This patch gives the ability to configure them the same way. This also helps with avoiding a special case in #107.
Currently, the make-<file>.sh scripts generate a make-<file> that is executed to obtain the <file> used for compiling. The end ./compile script goes from this: #!/bin/sh # WARNING: This file was auto-generated. Do not edit! exec cc -O2 -c "$@" to this: #!/bin/sh # WARNING: This file was auto-generated. Do not edit! CC='cc -O2' LD='cc -s' AR='ar' RANLIB='ranlib' exec $CC -c "$@" So this is a tradeoff between having shorter end-result ./compile, ./load and ./makelib scripts, and having a simpler build process: all .sh are now generated only with cat(1), and there is no script that generate a script anymore. An exception is ./auto-ccld.sh, which still takes its content from conf-* config files.
|
FYI: Just rebased it to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit address an independent point, with the global goal of making the toolchain simpler, and easier to rework with further on: #28, #2, #35, #107