Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated URLs for PreviewHTML plugin, and tested them. #85

Merged
merged 6 commits into from
Apr 27, 2019

Conversation

vor0nwe
Copy link
Contributor

@vor0nwe vor0nwe commented Apr 26, 2019

Even the query string separators need to be URI-encoded for some reason, otherwise the updater doesn't download the file.

@chcg chcg added this to the 1.0.9 milestone Apr 27, 2019
@chcg
Copy link
Contributor

chcg commented Apr 27, 2019

@vor0nwe Seems you are right. The download check via appveyor is currently just based on a pythonscript and doesn't directly use https://github.com/notepad-plus-plus/wingup the download component of N++ (an open task #36, to find such problems more easily). Thanks for the update.

@chcg chcg merged commit 924e8a1 into notepad-plus-plus:master Apr 27, 2019
@vor0nwe
Copy link
Contributor Author

vor0nwe commented Apr 27, 2019

Thanks!

The download check via appveyor is currently just based on a pythonscript and doesn't directly use https://github.com/notepad-plus-plus/wingup the download component of N++ (an open task, to find such problems more easily). Thanks for the update.

I think I'd rather mark this as a bug in WinGUp (notably the use of PathFindFileNameA on a URL without sanitizing the resulting file name, or even chopping off any parameters first)...

Edit: nevermind, I just saw that the bug has been reported already (in December last year).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants