Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check also gup download\unzip with validation tests #36

Open
chcg opened this issue Dec 20, 2018 · 5 comments
Open

check also gup download\unzip with validation tests #36

chcg opened this issue Dec 20, 2018 · 5 comments

Comments

@chcg
Copy link
Contributor

chcg commented Dec 20, 2018

See notepad-plus-plus/wingup#7
, which doesn't occur with download\unzip via python
, so do both python and gup and diff the results which should be identical

@chcg chcg changed the title check also gup download\unzip for validation tests check also gup download\unzip with validation tests Dec 20, 2018
@chcg
Copy link
Contributor Author

chcg commented Mar 17, 2024

See https://github.com/chcg/nppPluginList/tree/unique_test , but the run on github quite often fails due to gup download issues.

@donho
Copy link
Member

donho commented Mar 18, 2024

@chcg
What does the branch unique_test do ?

@chcg
Copy link
Contributor Author

chcg commented Mar 18, 2024

@donho Additionally to the download and checks via python the branch also used GUP for download and check via diff if GUP and python download are identical. The branch name is misleading.

@donho
Copy link
Member

donho commented Mar 18, 2024

OK, I see.

but the run on github quite often fails due to gup download issues.

What's the gup download issue then?

@chcg
Copy link
Contributor Author

chcg commented Mar 19, 2024

@donho It is failing randomly, see e.g. https://github.com/chcg/nppPluginList/actions/runs/7599924855/job/20697527979 or https://github.com/chcg/nppPluginList/actions/runs/7599924855/job/20697528091. Older builds don't have the logs available anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants