Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include MNIST training example + modify learning notebook #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cpehle
Copy link
Member

@cpehle cpehle commented Aug 31, 2021

No description provided.

Copy link
Member

@Jegp Jegp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have an MNIST example. And the learning page is much more illustrative than before. I think we should consider two things:

  • I appreciate removing the factual problems in the learning page, but I do think the current version is lacking some of the intuitive explanation I tried to provide before. The current page provides no introduction to spiking neurons, no explanation why we need surrogate gradients, and, in my opinion, not enough practical information on how to train SNNs with Norse. I think the details are great, but I would perhaps suggest keeping the (admittedly, really nice) visualization in a separate page about surrogate gradients. I would suggest the 'learning' page is a quick tour about how surrogate gradients work and how it's used in Norse.
  • There are red warnings/errors in the MNIST dataset and it doesn't compile. How about only using a limited dataset and set epoch=1 as default to avoid build-time slowdown? We can always ask people to augment the data/epochs if they need. I doubt that'll interfere with the purpose of the notebook.

@Jegp
Copy link
Member

Jegp commented Sep 20, 2021

Should this be closed, btw @cpehle ?

@Jegp Jegp closed this Sep 24, 2021
@cpehle cpehle reopened this Oct 6, 2021
@cpehle
Copy link
Member Author

cpehle commented Oct 6, 2021

I think this is still worth working on, the current documentation on learning is not consistent with my view of the role of surrogate gradients. We should try rigorously explain what the challenges in defining gradient based learning in spiking neural networks are, this is not really done by the current doc at the moment.

@cpehle cpehle added the documentation Improvements or additions to documentation label Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants