Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quantization works well with feed forward dynamics. Unfortunately, we used the functional API to implement recurrent layers, which makes it hard to optimize, since PyTorch doesn't recognize the layers.
activation
+ 2linear
layers.I like the second version, since that's exactly what a recurrent layer is. We could even go further and remove our recurrent functionals, since I suspect few people are using the functions directly and because it reduces maintainance. The current PR contains a suggestion on how the
LIFRecurrentCell
module could look like - and a test that demonstrates that it works.I'm eager to hear your opinion @cpehle! May also be interesting for you, @ChFrenkel