Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing filters on more requests #67

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Allowing filters on more requests #67

wants to merge 4 commits into from

Conversation

fbatiga
Copy link

@fbatiga fbatiga commented Nov 19, 2018

No description provided.

@mgaruccio
Copy link
Contributor

So the previous way this has been handled has been with new functions that have WithExtraParams added to the name rather than changing the original function so that the call signature isn't confusing. ultimately up to @norberteder on if he wants to continue that pattern or not.

@fbatiga
Copy link
Author

fbatiga commented Nov 19, 2018

@mgaruccio i've changed the signature of the get lists on board function to revert to the old signature and added a version withExtraParams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbatiga @mgaruccio