bucket logging: Change logrotate configuration from daily to hourly #8006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
naveenpaul1
reviewed
May 8, 2024
| @@ -30,8 +30,9 @@ | |||
|
|
|||
| /var/log/bucket_logs.log | |||
| { | |||
| daily | |||
| size 100k | |||
| hourly | |||
There was a problem hiding this comment.
hourly check is needed?
There was a problem hiding this comment.
@naveenpaul1 yes, Actually these logs should be uploaded to log buckets and which would be consumed by other process. Its not only when some bug happens. These are logs for bucket operations.
|
LGTM |
aspandey
force-pushed
the
hourly-logrotate
branch
from
7ae8a9e
to
69f306c
Compare
Changing conf to rotate the log file every hour if it meets minimum size criteria. hourly minsize 10 maxsize 50k It means that for every hour (01:00 AM, 02:00 AM and so on) when logrotate is called, it will see if the size of the log is atleast 10 bytes or not. If it is, it will rotate the logs. maxsize makes sure that if the log size is 50k or more than as soon as logrotate is executed this log will be rotated. Even if it happens every minute or 5 minutes or so. Signed-off-by: Ashish Pandey <aspandey@redhat.com>
aspandey
force-pushed
the
hourly-logrotate
branch
from
69f306c
to
864f9f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing conf to rotate the log file every hour if it meets minimum size criteria.
hourly
minsize 10
maxsize 50k
It means that for every hour (01:00 AM, 02:00 AM and so on) when logrotate is called, it will see if the size of the log is atleast 10 bytes or not. If it is, it will rotate the logs.
maxsize makes sure that if the log size is 50k or more than as soon as logrotate is executed this log will be rotated. Even if it happens every minute or 5 minutes or so.