Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | CLI Refactor Validation (Partial) - Part 2 #7928

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Mar 26, 2024

Explain the changes

Note: This PR is dependent on PR #7917.

  1. Change the require to the file name (instead of destructor in the require with the functions name).
  2. Change all functions that start with "verify" to "validate".
  3. Separate the file between general, bucket, account, and ip validations in the file.
  4. Create a function for checking the identifier for each command.
  5. Remove a duplicate test (cli account status without name and access_key).
  6. Remove dead code inside validate_bucket_args and validate_account_args.

Issues:

  1. GAP - we still want to call the validations function earlier in the code (some of them are after we fetch the data).

Testing Instructions:

  1. none
  • Doc added/updated
  • Tests added

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
…uire with the functions name)

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady self-assigned this Mar 26, 2024
@guymguym guymguym modified the milestones: 5.15.4, 5.16.0 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants