Update GMailinator to lates Mail #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just added the UUID in Info.plist.
The goal here is to make easier to understand and add new shortcuts to GMailinator. Any new addition should be straightforward on the main file. Also I gather several fixes for different thing over everyone's fork to get the following: Auto UUID on the build script; Most of the compilation warnings are gone, with exception of the deprecation to load the NIB. If I fix that, the Move To dialog simply does not show up; Also I got rid of a memory leak on the event creation. It as a tiny one and would take forever to impact real users but nevertheless it was a good catch.
|
FYI I tested the end product on my Mac OS X 10.11.5 machine with Mail 9.3 by cloning your repo and building it and it works great. Thanks for updating this. I hope the maintainer accepts your pull request. |
Mac OS Sierra updates
Fix mark as read/unread shortcuts
|
FYI @Townk this appears to be disabled in the latest version of Mail App. |
|
I pushed a new commit on my repo to address that a couple days ago. Check if that would work for you and let me know. |
|
Hey sorry for the delayed response as I'd missed your reply, but it looks like https://github.com/Townk/GMailinator master branch was last pushed Oct 25. @Townk, any chance you pushed somewhere else that I'm missing? Anyways I sincerely appreciate you keeping this updated as I rely on this rather extensively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also did a small refactor on the main class to make it easy to add new features on the future.