feat: add --skip-prelude hidden CLI option
#5033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezenovm
approved these changes
May 16, 2024
| @@ -250,12 +254,14 @@ pub fn check_crate( | |||
| deny_warnings: bool, | |||
| disable_macros: bool, | |||
| use_elaborator: bool, | |||
| skip_prelude: bool, | |||
There was a problem hiding this comment.
It would probably be good to start grouping these together. It looks like in a lot of tests we just have four false variables being passed through.
Maybe we could put these options on the Context to easily thread them to other passes as well. This is non-blocking but just a thought
|
@michaeljklein I see you marked this as a draft? Is this to add a |
|
If this is ready I'd like it as well for testing the elaborator |
|
Michael's out today so I'm going to merge this. |
TomAFrench
changed the title
--skip-prelude hidden CLI option, skip inject_prelude when true--skip-prelude hidden CLI option
auto-merge was automatically disabled
May 27, 2024 13:14
Merge queue setting changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Usually, when debugging programs, they can be converted to a
noirc_frontend/tests.rstest with or without including the stdlib/prelude.However, workspace and multi-file-specific cases can be tedious to debug when the failing file has ~10 LOC and most of the context / parsing / type checking / etc. is all stdlib.
Summary*
Adds
--skip-preludeflag to skip callinginject_preludewhen collecting definitions.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.