-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use plain integer addresses for opcodes in DAP disassembly view #4941
fix: Use plain integer addresses for opcodes in DAP disassembly view #4941
Conversation
Returning serialized opcode locations is invalid according to the DAP specification and confuses VS.Code.
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this. :)
chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081) chore: update `nargo info` table to remove circuit size column feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080) fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941) chore(experimental): Elaborate globals (noir-lang/noir#5069) chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066) feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058) chore: use `bbup` to install `bb` (noir-lang/noir#5073) feat: Sync from aztec-packages (noir-lang/noir#5070) chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071) feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050) fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049)
…r-lang/noir#5097) chore(docs): Link to evmdiff for supported EVM chains (noir-lang/noir#5107) chore: Avoid creating witness for simple multiplications (noir-lang/noir#5100) feat: Add intrinsic to get if running inside an unconstrained context (noir-lang/noir#5098) chore: Move turbofish changes to the elaborator (noir-lang/noir#5094) fix: Apply self type from generic trait constraint before instantiating identifiers (noir-lang/noir#5087) chore: reactivate gates report (noir-lang/noir#5084) chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081) chore: update `nargo info` table to remove circuit size column feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080) fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941) chore(experimental): Elaborate globals (noir-lang/noir#5069) chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066) feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058) chore: use `bbup` to install `bb` (noir-lang/noir#5073) feat: Sync from aztec-packages (noir-lang/noir#5070) chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071) feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050) fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049)
…5097) chore(docs): Link to evmdiff for supported EVM chains (noir-lang/noir#5107) chore: Avoid creating witness for simple multiplications (noir-lang/noir#5100) feat: Add intrinsic to get if running inside an unconstrained context (noir-lang/noir#5098) chore: Move turbofish changes to the elaborator (noir-lang/noir#5094) fix: Apply self type from generic trait constraint before instantiating identifiers (noir-lang/noir#5087) chore: reactivate gates report (noir-lang/noir#5084) chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081) chore: update `nargo info` table to remove circuit size column feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080) fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941) chore(experimental): Elaborate globals (noir-lang/noir#5069) chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066) feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058) chore: use `bbup` to install `bb` (noir-lang/noir#5073) feat: Sync from aztec-packages (noir-lang/noir#5070) chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071) feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050) fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049)
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: Consider block parameters in variable liveness (noir-lang/noir#5097) chore(docs): Link to evmdiff for supported EVM chains (noir-lang/noir#5107) chore: Avoid creating witness for simple multiplications (noir-lang/noir#5100) feat: Add intrinsic to get if running inside an unconstrained context (noir-lang/noir#5098) chore: Move turbofish changes to the elaborator (noir-lang/noir#5094) fix: Apply self type from generic trait constraint before instantiating identifiers (noir-lang/noir#5087) chore: reactivate gates report (noir-lang/noir#5084) chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081) chore: update `nargo info` table to remove circuit size column feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080) fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941) chore(experimental): Elaborate globals (noir-lang/noir#5069) chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066) feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058) chore: use `bbup` to install `bb` (noir-lang/noir#5073) feat: Sync from aztec-packages (noir-lang/noir#5070) chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071) feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050) fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: sirasistant <sirasistant@gmail.com>
Description
Problem*
Resolves #4904
The disassembly view from VS.Code didn't work properly. Sometimes it would only show the first opcode only and once open it wouldn't update the current opcode pointer when stepping through the code. This was because we were using opcode locations (eg.
3.17
) as instruction references (typed as string in the API), but VS.Code expects integers either in decimal or hexadecimal format.Summary*
This PR updates the disassembly request DAP command handler to return integer addresses only, and changes the instruction set breakpoint command to parse and map the given address to the appropriate opcode location.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.