Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update using-devcontainers.mdx #4844

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ziyinlox-purple
Copy link

Description

Problem*

Resolves #4680

Summary*

Supplementing the missing creation step 7

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

This improvement was already discussed in noir-lang#4680
Copy link
Contributor

Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.

@TomAFrench TomAFrench requested a review from a team April 20, 2024 23:56
@signorecello
Copy link
Contributor

Hey @ziyinlox-purple thanks for your contrib and bugfix. Can I ask if you could put these commands inside the Dockerfile itself or in the "onCreateCommand" property of devcontainer.json?

Totally fine if you don't feel like it, just let me know and I can do it. We could then merge this one :)

Copy link
Contributor

@signorecello signorecello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking stuff

@ziyinlox-purple
Copy link
Author

Hey @ziyinlox-purple thanks for your contrib and bugfix. Can I ask if you could put these commands inside the Dockerfile itself or in the "onCreateCommand" property of devcontainer.json?

Totally fine if you don't feel like it, just let me know and I can do it. We could then merge this one :)

ok,I will put it into the devcontainer.json

1. add commit and push command in `devcontainer.json`
2. change the previous operation descriptions
@ziyinlox-purple
Copy link
Author

Hey @ziyinlox-purple thanks for your contrib and bugfix. Can I ask if you could put these commands inside the Dockerfile itself or in the "onCreateCommand" property of devcontainer.json?

Totally fine if you don't feel like it, just let me know and I can do it. We could then merge this one :)

Have done, check it please.

Copy link
Contributor

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only relevant for v0.26? You are only updating this version.

@ziyinlox-purple
Copy link
Author

ziyinlox-purple commented Apr 25, 2024 via email

@catmcgee
Copy link
Contributor

@ziyinlox-purple the noir docs are versioned. if you want to update the recent version, you need to update this file (and optionally this one)

@ziyinlox-purple
Copy link
Author

ziyinlox-purple commented May 1, 2024 via email

moving the changes to v0.28.0 and recover the changes of  v0.26.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: One step is missing in docs
4 participants