src: add log API #135
Merged
src: add log API #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
requested changes
May 20, 2024
trevnorris
force-pushed
the
trevnorris/log-api
branch
3 times, most recently
from
0057589
to
2fc3e37
Compare
santigimeno
approved these changes
May 24, 2024
Comment on lines
+222
to
+224
| function writeLog(msg, sev) { | ||
| binding.writeLog(typeof msg === 'string' ? msg : JSONStringify(msg), sev); | ||
| } |
There was a problem hiding this comment.
Should we check other types as well such as Buffer? I don't really know tbh
There was a problem hiding this comment.
That's a good idea, but I wasn't sure if we should match how console.log() works on output.
santigimeno
reviewed
May 24, 2024
Add a C++ API to collect logs written with the nsolid JS API. PR-UR: #135 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
force-pushed
the
trevnorris/log-api
branch
from
2fc3e37
to
9c79696
Compare
santigimeno
approved these changes
May 30, 2024
Comment on lines
+1828
to
+1833
| template <typename G> | ||
| void on_log_write_hook_proxy_(SharedEnvInst inst, | ||
| LogWriteInfo info, | ||
| void* data) { | ||
| (*static_cast<G*>(data))(inst, std::move(info)); | ||
| } |
There was a problem hiding this comment.
Does the compiler know how to move LogWriteInfo or do we have to implement the move constructor ourselves?
There was a problem hiding this comment.
LogWriteInfo contains only standard types that it knows how to move. So we should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a C++ API to collect logs written with the nsolid JS API.
Log support for Winston and Pino will also be added.