agents: add metrics transform API to agent #123
Conversation
trevnorris
force-pushed
the
trevnorris/transform-statsd
branch
6 times, most recently
from
7df5555
to
f08389e
Compare
| if (Inst().get() == this) { | ||
| ASSERT_EQ(0, OnConfigurationHook(config_agent_cb, weak_from_this())); | ||
| } |
There was a problem hiding this comment.
This is because of the test right? Why aren't you adding the ThreadAdded/RemovedHook methods inside that conditional as well?
There was a problem hiding this comment.
Mostly because I am being lazy. There are two main assumptions:
- A
StatsDAgentinstance will be used for the entire process lifetime - At most 2
StatsDAgentinstances will ever be created.
Using these assumptions, I decided it would be easier for each StatsDAgent instance to set up its own hooks to check when a new thread is created/destroyed rather than have a single global hook that would iterate through a list of StatsDAgent instances when a thread is created/destroyed. This simplified the logic a lot and will be easy to fix if we ever add the ability to remove a hook.
Though, now that I type this up I realize that all the stuff I added for the agent_list_ can be removed. Since it was never used. Will make that change.
Add API to allow retrieving all currently available SharedEnvInst instances. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
The user shouldn't have access to start/stop. No need to expose them. Also remove stop() completely. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Allow users to register a callback that will transform the metrics into a std::string that will be written to the endpoint. In order to do this some of the internals needed to be rewritten so that config() could be called from any thread. The internal usage of config() has been renamed since it will always be called from the StatsDAgent thread. PR-URL: #123 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
force-pushed
the
trevnorris/transform-statsd
branch
from
f08389e
to
9b03aaa
Compare
Allow users to register a callback that will transform the metrics into a std::string that will be written to the endpoint.
Still working on tests.