Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cron fixes, part 2 (+) #2515

Merged
merged 2 commits into from Oct 10, 2018
Merged

Cron fixes, part 2 (+) #2515

merged 2 commits into from Oct 10, 2018

Conversation

nwf
Copy link
Member

@nwf nwf commented Oct 9, 2018

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/en/*.

@nwf
Restore WRAPCC when building lua
b33dc97 
Replay commit a57fe55
('app/lua/luac_cross: WRAPCC CC here, too (nodemcu#2453)') lost in intervening
updates.
@nwf
cron: fix several parsing bugs
45a5539 
Gobble excess whitespace before columns as well as after all columns

*/n parsing now always includes the minimum entry and goes from there,
rather than having its phase be offset by the field's minimum value,
which seemed odd.  (That is, "*/k" with k > min is now equivalent to
"min+0k,min+1k,..." rather than "1k-min,2k-min,...")

Remove an entirely superfluous test of end in */n parsing (it was
always true anyway and appears to have been accidental).
@nwf
Copy link
Member Author

nwf commented Oct 9, 2018

Also unrelated to #2512 except that I had my fingers in the code.

@marcelstoer marcelstoer added this to the Next Release milestone Oct 10, 2018
@marcelstoer
Copy link
Member

Thanks @nwf! If we had unit tests (#2145) these bugs would most likely have been found long before.

@marcelstoer marcelstoer merged commit 3c824d7 into nodemcu:dev Oct 10, 2018
@nwf nwf deleted the cron branch February 18, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix enhancement
Projects
None yet
Milestone
LFS follow-up
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nwf @marcelstoer