Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct same level side navigation on breadcrumbs #6710

Merged
merged 2 commits into from May 21, 2024

Conversation

tquocanvn
Copy link
Contributor

Description

  • Update side bar navigation key name to match with route path in navigation.json
  • Add target side bar nav keys to HOC withBreadcrumbs.tsx to get directly sidebar navigation data for About.tsx and Learn.tsx page.
  • Update logic on matching route path in function getBreadrumbs of HOC withBreadcrumbs.tsx.

Validation

  • Open page path /en/about/, go through all items in side bar navigation to see it shows correct breadcrumbs data.

6679

Related Issues

Fixes #6679

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@tquocanvn tquocanvn requested a review from a team as a code owner May 4, 2024 17:09
Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 4, 2024 5:11pm

Copy link

github-actions bot commented May 4, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 97 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

Copy link

github-actions bot commented May 4, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.04% (588/653) 76.08% (175/230) 92.18% (118/128)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 💤 0 ❌ 0 🔥 6.137s ⏱️

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for your first contribution.

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue May 21, 2024
@bmuenzenmeyer
Copy link
Collaborator

thanks for this thoughtful contribution @tquocanvn - sorry for the delay!

Merged via the queue into nodejs:main with commit 04f8989 May 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency of breadcrumbs detail shown in about page of the website
4 participants