feat: Navigation state provider and hook #6709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary workaround for nodejs#6409 Get more info here - nodejs#6675 Signed-off-by: abizek <abishekilango@protonmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
abizek
commented
May 4, 2024
abizek
commented
May 4, 2024
abizek
commented
May 4, 2024
Closed
ovflowd
reviewed
May 12, 2024
ovflowd
reviewed
May 12, 2024
ovflowd
reviewed
May 12, 2024
ovflowd
reviewed
May 12, 2024
|
@abizek this is looking good! I left a few minor comments/suggestions and ideas :) |
Signed-off-by: abizek <abishekilango@protonmail.com>
|
@ovflowd I refactored the effect and responded to some of your comments. Please take a look. |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
ovflowd
reviewed
May 15, 2024
AugustinMauroy
approved these changes
May 15, 2024
Signed-off-by: abizek <abishekilango@protonmail.com>
github-actions
bot
removed
the
github_actions:pull-request
aymen94
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Navigation State provider and hook to track scroll position and restore it on remount.
Validation
Related Issues
Temporary workaround for #6409
Get more info here - #6675 (comment)
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.