doc: add release key for marco-ippolito #52257

marco-ippolito · 2024-03-28T18:24:31Z

Refs: nodejs/Release#984

nodejs-github-bot · 2024-03-28T18:24:36Z

Review requested:

@nodejs/tsc

doc/contributing/releases.md

github-actions · 2024-03-28T23:15:54Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @richardlau.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

README.md

mcollina

lgtm

mcollina · 2024-03-30T08:49:07Z

congrats!

nodejs-github-bot · 2024-03-30T19:05:51Z

Commit Queue failed

- Loading data for nodejs/node/pull/52257 ✔ Done loading data for nodejs/node/pull/52257 ----------------------------------- PR info ------------------------------------ Title doc: add release key for marco-ippolito (#52257) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:fix/gpg-key-doc -> nodejs:main Labels doc, meta, notable-change, lts-watch-v18.x, lts-watch-v20.x Commits 2 - doc: add release key for marco-ippolito - doc: update release gpg keyserver Committers 1 - marco-ippolito PR-URL: https://github.com/nodejs/node/pull/52257 Refs: https://github.com/nodejs/Release/issues/984 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Ruy Adorno Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52257 Refs: https://github.com/nodejs/Release/issues/984 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Ruy Adorno Reviewed-By: Rafael Gonzaga Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 28 Mar 2024 18:24:31 GMT ✔ Approvals: 6 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/52257#pullrequestreview-1967201865 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52257#pullrequestreview-1967272716 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/52257#pullrequestreview-1968716357 ✔ - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/52257#pullrequestreview-1968821626 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/52257#pullrequestreview-1969332476 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/52257#pullrequestreview-1969867975 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52257 From https://github.com/nodejs/node * branch refs/pull/52257/merge -> FETCH_HEAD ✔ Fetched commits as 021cf9120840..fdb3bd426d91 -------------------------------------------------------------------------------- [main 5887931548] doc: add release key for marco-ippolito Author: marco-ippolito Date: Thu Mar 28 19:16:33 2024 +0100 1 file changed, 3 insertions(+) [main 41a32b5c46] doc: update release gpg keyserver Author: marco-ippolito Date: Thu Mar 28 19:08:48 2024 +0100 1 file changed, 6 insertions(+), 5 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: add release key for marco-ippolito

PR-URL: #52257
Refs: nodejs/Release#984
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Ruy Adorno ruy@vlt.sh
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

[detached HEAD d6c63748bb] doc: add release key for marco-ippolito
Author: marco-ippolito marcoippolito54@gmail.com
Date: Thu Mar 28 19:16:33 2024 +0100
1 file changed, 3 insertions(+)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: update release gpg keyserver

PR-URL: #52257
Refs: nodejs/Release#984
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Ruy Adorno ruy@vlt.sh
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

[detached HEAD d828d83922] doc: update release gpg keyserver
Author: marco-ippolito marcoippolito54@gmail.com
Date: Thu Mar 28 19:08:48 2024 +0100
1 file changed, 6 insertions(+), 5 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/8492794469

anonrig · 2024-03-30T19:29:32Z

doc/contributing/releases.md

+The public keys should be fetchable from a known third-party keyserver.
+The OpenPGP keyserver at <https://keys.openpgp.org/> is recommended.
+Use the [submission](https://keys.openpgp.org/upload) form to submit
+a new public key, and make sure to verify the associated email.
+You'll need to do an ASCII-armored export of your key first:


IMHO, I think we should make this change on a different pull-request.

It's split in two commits, the current onboarding documentation is wrong, and since I was following it, I took the chance to update it

anonrig · 2024-03-30T19:30:09Z

doc/contributing/releases.md

@@ -102,7 +103,7 @@ gpg --armor --export email@server.com > ~/nodekey.asc
 Keys should be fetchable via:

 ```bash
-gpg --keyserver pool.sks-keyservers.net --recv-keys <FINGERPRINT>
+gpg --keyserver hkps://keys.openpgp.org --recv-keys <FINGERPRINT>


Why is this change made here? I couldn't find any public reasoning for this.

@anonrig FYI #29531

nodejs-github-bot · 2024-03-31T06:36:48Z

Landed in 021cf91...903f28e

PR-URL: #52257 Refs: nodejs/Release#984 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: TODO

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) support forced exit (Colin Ihrig) #52038 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: #52793

PR-URL: #52257 Refs: nodejs/Release#984 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) #52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) #52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) #52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) #52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) #51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) #51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) #52492 doc: * update release gpg keyserver (marco-ippolito) #52257 * add release key for marco-ippolito (marco-ippolito) #52257 * add UlisesGascon as a collaborator (Ulises Gascón) #51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) #51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) #52618 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) #52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) #52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) #51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) #52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) #51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) #52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) #51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) #51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) #52127 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) #51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) #52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) #51927 watch: * mark as stable (Moshe Atlow) #52074 PR-URL: #52793

Notable changes: benchmark: * add AbortSignal.abort benchmarks (Raz Luvaton) nodejs#52408 buffer: * improve `base64` and `base64url` performance (Yagiz Nizipli) nodejs#52428 crypto: * deprecate implicitly shortened GCM tags (Tobias Nießen) nodejs#52345 deps: * (SEMVER-MINOR) update simdutf to 5.0.0 (Daniel Lemire) nodejs#52138 * (SEMVER-MINOR) update undici to 6.3.0 (Node.js GitHub Bot) nodejs#51462 * (SEMVER-MINOR) update undici to 6.2.1 (Node.js GitHub Bot) nodejs#51278 dns: * (SEMVER-MINOR) add order option and support ipv6first (Paolo Insogna) nodejs#52492 doc: * update release gpg keyserver (marco-ippolito) nodejs#52257 * add release key for marco-ippolito (marco-ippolito) nodejs#52257 * add UlisesGascon as a collaborator (Ulises Gascón) nodejs#51991 * (SEMVER-MINOR) deprecate fs.Stats public constructor (Marco Ippolito) nodejs#51879 events,doc: * mark CustomEvent as stable (Daeyeon Jeong) nodejs#52618 fs: * add stacktrace to fs/promises (翠 / green) nodejs#49849 lib, url: * (SEMVER-MINOR) add a `windows` option to path parsing (Aviv Keller) nodejs#52509 net: * (SEMVER-MINOR) add CLI option for autoSelectFamilyAttemptTimeout (Paolo Insogna) nodejs#52474 report: * (SEMVER-MINOR) add `--report-exclude-network` option (Ethan Arrowood) nodejs#51645 src: * (SEMVER-MINOR) add `string_view` overload to snapshot FromBlob (Anna Henningsen) nodejs#52595 * (SEMVER-MINOR) add C++ ProcessEmitWarningSync() (Joyee Cheung) nodejs#51977 * (SEMVER-MINOR) add uv_get_available_memory to report and process (theanarkh) nodejs#52023 * (SEMVER-MINOR) preload function for Environment (Cheng Zhao) nodejs#51539 stream: * (SEMVER-MINOR) support typed arrays (IlyasShabi) nodejs#51866 test_runner: * (SEMVER-MINOR) add suite() (Colin Ihrig) nodejs#52127 * (SEMVER-MINOR) add `test:complete` event to reflect execution order (Moshe Atlow) nodejs#51909 util: * (SEMVER-MINOR) support array of formats in util.styleText (Marco Ippolito) nodejs#52040 v8: * (SEMVER-MINOR) implement v8.queryObjects() for memory leak regression testing (Joyee Cheung) nodejs#51927 watch: * mark as stable (Moshe Atlow) nodejs#52074 PR-URL: nodejs#52793

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 28, 2024

marco-ippolito mentioned this pull request Mar 28, 2024

Nominating @marco-ippolito to releasers nodejs/Release#984

Closed

marco-ippolito added the meta Issues and PRs related to the general management of the project. label Mar 28, 2024

aduh95 reviewed Mar 28, 2024

View reviewed changes

doc/contributing/releases.md Outdated Show resolved Hide resolved

aduh95 reviewed Mar 28, 2024

View reviewed changes

doc/contributing/releases.md Outdated Show resolved Hide resolved

aduh95 reviewed Mar 28, 2024

View reviewed changes

doc/contributing/releases.md Outdated Show resolved Hide resolved

marco-ippolito force-pushed the fix/gpg-key-doc branch from 4df48b3 to 5f79b2f Compare March 28, 2024 19:49

marco-ippolito requested a review from RafaelGSS March 28, 2024 20:04

marco-ippolito force-pushed the fix/gpg-key-doc branch from 5f79b2f to 661d5ed Compare March 28, 2024 20:09

marco-ippolito requested a review from aduh95 March 28, 2024 20:11

aduh95 approved these changes Mar 28, 2024

View reviewed changes

lpinca approved these changes Mar 28, 2024

View reviewed changes

richardlau added notable-change PRs with changes that should be highlighted in changelogs. lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels Mar 28, 2024

richardlau reviewed Mar 28, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

marco-ippolito force-pushed the fix/gpg-key-doc branch from 661d5ed to 7bd3489 Compare March 29, 2024 14:51

richardlau reviewed Mar 29, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

marco-ippolito added 2 commits March 29, 2024 15:56

doc: add release key for marco-ippolito

189bb09

doc: update release gpg keyserver

fdb3bd4

marco-ippolito force-pushed the fix/gpg-key-doc branch from 7bd3489 to fdb3bd4 Compare March 29, 2024 14:56

richardlau approved these changes Mar 29, 2024

View reviewed changes

ruyadorno approved these changes Mar 29, 2024

View reviewed changes

RafaelGSS approved these changes Mar 29, 2024

View reviewed changes

mertcanaltin approved these changes Mar 29, 2024

View reviewed changes

mcollina approved these changes Mar 30, 2024

View reviewed changes

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2024

anonrig reviewed Mar 30, 2024

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2024

nodejs-github-bot closed this Mar 31, 2024

RafaelGSS mentioned this pull request Apr 15, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

marco-ippolito mentioned this pull request May 2, 2024

v20.13.0 proposal #52793

Merged

richardlau added backported-to-v18.x PRs backported to the v18.x-staging branch. backported-to-v20.x PRs backported to the v20.x-staging branch. and removed lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels May 16, 2024

richardlau mentioned this pull request May 16, 2024

v18.20.3 proposal #53028

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: add release key for marco-ippolito #52257

doc: add release key for marco-ippolito #52257

marco-ippolito commented Mar 28, 2024

nodejs-github-bot commented Mar 28, 2024

github-actions bot commented Mar 28, 2024

mcollina left a comment

mcollina commented Mar 30, 2024

nodejs-github-bot commented Mar 30, 2024

Successfully rebased and updated refs/heads/main.

anonrig Mar 30, 2024

marco-ippolito Mar 31, 2024

anonrig Mar 30, 2024

richardlau Mar 31, 2024

nodejs-github-bot commented Mar 31, 2024

doc: add release key for marco-ippolito #52257

doc: add release key for marco-ippolito #52257

Conversation

marco-ippolito commented Mar 28, 2024

nodejs-github-bot commented Mar 28, 2024

github-actions bot commented Mar 28, 2024

mcollina left a comment

Choose a reason for hiding this comment

mcollina commented Mar 30, 2024

nodejs-github-bot commented Mar 30, 2024

Successfully rebased and updated refs/heads/main.

anonrig Mar 30, 2024

Choose a reason for hiding this comment

marco-ippolito Mar 31, 2024

Choose a reason for hiding this comment

anonrig Mar 30, 2024

Choose a reason for hiding this comment

richardlau Mar 31, 2024

Choose a reason for hiding this comment

nodejs-github-bot commented Mar 31, 2024