Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: wait promise resolve before print result #52077

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/internal/process/execution.js
Expand Up @@ -119,7 +119,10 @@ function evalScript(name, body, breakFirstLine, print, shouldLoadESM = false) {
});
if (print) {
const { log } = require('internal/console/global');
log(result);

process.on('exit', async () => {
log(await result);
Comment on lines +123 to +124
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns would be addressed if we removed the await here.

Suggested change
process.on('exit', async () => {
log(await result);
process.on('exit', () => {
log(result);

});
}

if (origModule !== undefined)
Expand Down
41 changes: 33 additions & 8 deletions test/parallel/test-cli-print-promise.mjs
Expand Up @@ -15,7 +15,7 @@ describe('--print with a promise', { concurrency: true }, () => {
code: 0,
signal: null,
stderr: '',
stdout: 'Promise { 42 }\n',
stdout: '42\n',
});
});

Expand All @@ -29,7 +29,7 @@ describe('--print with a promise', { concurrency: true }, () => {
code: 0,
signal: null,
stderr: '',
stdout: 'Promise { <pending> }\n',
stdout: '42\n',
});
});

Expand All @@ -43,7 +43,7 @@ describe('--print with a promise', { concurrency: true }, () => {
code: 0,
signal: null,
stderr: '',
stdout: 'Promise { <pending> }\n',
stdout: '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's acceptable.

});
});

Expand All @@ -57,11 +57,11 @@ describe('--print with a promise', { concurrency: true }, () => {
code: 0,
signal: null,
stderr: '',
stdout: 'Promise { <pending> }\n',
stdout: '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

});
});

it('should handle rejected promises', async () => {
it('should handle rejected promises with unhandled-rejections=none', async () => {
const result = await spawnPromisified(execPath, [
'--unhandled-rejections=none',
'--print',
Expand All @@ -72,11 +72,11 @@ describe('--print with a promise', { concurrency: true }, () => {
code: 0,
signal: null,
stderr: '',
stdout: 'Promise { <rejected> 1 }\n',
stdout: '',
Copy link
Contributor

@aduh95 aduh95 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. I would consider that change semver-major if we stick with it.

});
});

it('should handle promises that reject after one tick', async () => {
it('should handle promises that reject after one tick with unhandled-rejections=none', async () => {
const result = await spawnPromisified(execPath, [
'--unhandled-rejections=none',
'--print',
Expand All @@ -87,7 +87,32 @@ describe('--print with a promise', { concurrency: true }, () => {
code: 0,
signal: null,
stderr: '',
stdout: 'Promise { <pending> }\n',
stdout: '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

});
});

it('should error with unhandled rejected promises', async () => {
const result = await spawnPromisified(execPath, [
'--print',
'Promise.reject(1)',
]);

assert.strictEqual(result.code, 1);
assert.strictEqual(result.signal, null);
assert.strictEqual(result.stdout, '');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

assert.ok(result.stderr.includes('ERR_UNHANDLED_REJECTION'), 'Not found ERR_UNHANDLED_REJECTION');
});

it('should error when throw inside fn', async () => {
const result = await spawnPromisified(execPath, [
'--print',
'Promise.resolve().then(()=>{throw new Error(10)})',
]);

assert.strictEqual(result.code, 1);
assert.strictEqual(result.signal, null);
assert.strictEqual(result.stdout, '');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

assert.ok(result.stderr.includes('throw new Error(10)'), `Found: ${result.stderr}`);
assert.ok(result.stderr.includes('Error: 10'), `Found: ${result.stderr}`);
});
});