events: improve performance caused by primordials #30577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
events
cjihrig
approved these changes
Nov 21, 2019
lib/events.js
Outdated
| ownKeys: ReflectOwnKeys, | ||
| } | ||
| } = primordials; | ||
| const apply = ReflectApply; |
There was a problem hiding this comment.
The variables ReflectApply and apply are the same thing. I think one of them can be removed.
There was a problem hiding this comment.
That's right. I have changed it. Thanks!
antimonyGu
force-pushed
the
events-primordials
branch
from
916086e
to
175a3a5
Compare
targos
approved these changes
Nov 21, 2019
ZYSzys
approved these changes
Nov 22, 2019
|
Dear all reviewers, I see several builds fails on Jenkins, and most of them seem like a same problem. But I don't know how to fix them and the exact reason of the failure reason. Can anybody help me? Thanks very much! |
gireeshpunathil
approved these changes
Nov 22, 2019
|
@antimonyGu - there were unrelated issues that caused this failures, not a cause of worry for you! those are being addressed, so I have re-triggered the CI. Let us see! |
|
@gireeshpunathil Thanks very much! |
|
Please 👍 to fast-track. |
Trott
pushed a commit
that referenced
this pull request
Nov 23, 2019
PR-URL: #30577 Refs: nodejs/code-and-learn#97 Refs: #29766 Refs: #29633 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
|
Landed in e5cbbe0. Thanks for the contribution! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30577 Refs: nodejs/code-and-learn#97 Refs: #29766 Refs: #29633 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30577 Refs: nodejs/code-and-learn#97 Refs: #29766 Refs: #29633 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30577 Refs: nodejs/code-and-learn#97 Refs: #29766 Refs: #29633 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Refs: nodejs/code-and-learn#97
Refs: #29766
Refs: #29633
make -j4 test(UNIX), orvcbuild test(Windows) passes