ci: add nodejs integration on macos/linux #255
Conversation
legendecas
force-pushed
the
node-integration
branch
from
c72d057
to
0fc44d9
Compare
legendecas
changed the title
.github/workflows/nodejs.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [macos-latest, macos-14, ubuntu-latest] |
There was a problem hiding this comment.
macos-latest and macos-14 are exactly the same:
https://github.com/nodejs/gyp-next/actions/runs/9015778952/job/24771097889?pr=255
https://github.com/nodejs/gyp-next/actions/runs/9015778952/job/24771097430?pr=255
See "Set up job" -> "Operating System" and "Runner Image"
There was a problem hiding this comment.
Ah, thanks for pointing this out. I copied this from https://github.com/nodejs/gyp-next/blob/main/.github/workflows/node-gyp.yml#L13. I'll remove this duplication.
There was a problem hiding this comment.
macos-13 is Intel ($runner.arch==X64)
macos-14 is Apple Silicon ($runner.arch==ARM64)
macos-latest is a rolling transition for 12 weeks from April 1st. (Unless someone can point to newer docs from GitHub.)
GitHub Actions blog:
Over the next 12 weeks, jobs using the
macos-latestrunner label will migrate from macOS 12 (Monterey) to macOS 14 (Sonoma).
| fail-fast: false | ||
| matrix: | ||
| os: [macos-latest, macos-14, ubuntu-latest] | ||
| python: ["3.8", "3.10", "3.12"] |
There was a problem hiding this comment.
Test the beta? https://www.python.org/download/pre-releases/
| python: ["3.8", "3.10", "3.12"] | |
| python: ["3.8", "3.10", "3.12", "3.13"] |
There was a problem hiding this comment.
https://github.com/nodejs/node/blob/main/configure#L27 doesn't accept 3.13 yet
.github/workflows/nodejs.yml
Outdated
| cd node | ||
| ./configure | ||
|
|
||
| integration-windows: |
There was a problem hiding this comment.
These Windows jobs take a long time!
There was a problem hiding this comment.
I think it could be enough to run the configure step instead of running all the build. In this way it could be much faster.
There was a problem hiding this comment.
Updated to run configure only.
|
Why merge all this complexity into a single file? |
legendecas
force-pushed
the
node-integration
branch
from
f705fb2
to
408afd1
Compare
Most steps are similar in the integration tests, except from platform differences. |
legendecas
force-pushed
the
node-integration
branch
from
26d9d6e
to
b182b43
Compare
Add node-integration test to ensure the vendored
packagingwill not be removed by accident.Refs: #250 (comment)
Fixes: #31