Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error format requires a mapping #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpcalisi
Copy link

Fix:

run gyp without arguments doesn't show right usage

c108df569f5e:/work# gyp
Traceback (most recent call last):
  File "/usr/bin/gyp", line 8, in <module>
    sys.exit(script_main())
             ^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/gyp/__init__.py", line 688, in script_main
    return main(sys.argv[1:])
           ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/gyp/__init__.py", line 680, in main
    return gyp_main(args)
           ^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/gyp/__init__.py", line 553, in gyp_main
    raise GypError((usage + "\n\n%s: error: no build_file") % (my_name, my_name))
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
TypeError: format requires a mapping
c108df569f5e:/work#

Signed-off-by: Lucas Pablo Calisi <lucas.calisi@mercadolibre.com>
@cclauss
Copy link
Contributor

cclauss commented Oct 20, 2023

Please add a test that proves that we have a problem today and that the proposed solution fixes that problem. Please feel free to use f-strings for speed.

@cclauss
Copy link
Contributor

cclauss commented Apr 29, 2024

Wrong repo: pipx run gyp-next, not gyp!

That currently generates a different error that should be fixed by

@cclauss cclauss added wontfix This will not be worked on python Pull requests that update Python code labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants