fix: failure when build directory contains spaces #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an installation issue that occurs when a path in which node-gyp is run contains spaces. For a path like `my app`, it would error with this message: ``` clang: error: no such file or directory: 'app/node_modules/node-addon-api' ``` The "my" part before the space (and the rest of the path before it) would be missing from the path in the error message. Fixes nodejs/node-gyp#65
tombruijn
force-pushed
the
fix-includes-path-with-spaces
branch
from
a1e7c01
to
87c51bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an installation issue that occurs when a path in which node-gyp is run contains spaces.
For a path like
my app, it would error with this message:The "my" part before the space (and the rest of the path before it) would be missing from the path in the error message.
Fixes nodejs/node-gyp#65