fix: duplicate ninja rules for v8 (cross-compiling) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Feb 19, 2023
|
Please rebase. |
moto-timo
force-pushed
the
fix-v8-ninja-cross-compiling
branch
2 times, most recently
from
09e3ad8
to
58e88cf
Compare
|
Rebased again. |
avoids duplicate ninja rules for v8 used in host and target From: minrk/node@5e533cb Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Reported in nodejs/node#46690 and nodejs/node#37441 Minor refactoring as recommended by Christian Clauss. Signed-off-by: Tim Orling <tim.orling@konsulko.com>
moto-timo
force-pushed
the
fix-v8-ninja-cross-compiling
branch
from
58e88cf
to
ef910d3
Compare
|
Rebased to pick up the |
|
@cclauss I believe I addressed your recommendations and rebase concerns. Anything else that needs to be done or any more discussion? |
|
This pull request is rebased and the tests are all green. ✅ Thanks for that. Now what we need is some maintainer who has enough expertise to review and approve or make suggestions. |
|
@cclauss great. Thank you for the response. |
|
I can confirm that this goes with the default naming conventions of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids duplicate ninja rules for v8 used in host and target
From: minrk/node@5e533cb
Reported in nodejs/node#46690 and nodejs/node#37441