Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test integration with Node.js and node-gyp with GH actions #31

Open
targos opened this issue Apr 3, 2020 · 0 comments · May be fixed by #255
Open

Test integration with Node.js and node-gyp with GH actions #31

targos opened this issue Apr 3, 2020 · 0 comments · May be fixed by #255

Comments

@targos
Copy link
Member

targos commented Apr 3, 2020

I think we should make separate workflow files so they can be restarted independently.

For Node.js:

  • Clone nodejs/node
  • Replace tools/gyp with the code from the PR/branch being tested
  • Check that Node can be built

For node-gyp:

  • clone nodejs/node-gyp
  • Replace gyp with the code from the PR/branch being tested
  • Check that tests pass
@legendecas legendecas linked a pull request May 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant