Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Node.js Code + Learn at COSCon'19 (China Open Source Conf) #97

Open
6 of 8 tasks
XadillaX opened this issue Sep 2, 2019 · 14 comments
Open
6 of 8 tasks

Node.js Code + Learn at COSCon'19 (China Open Source Conf) #97

XadillaX opened this issue Sep 2, 2019 · 14 comments

Comments

@XadillaX
Copy link
Member

XadillaX commented Sep 2, 2019

COSCon'18 wanted to hold C+L but finally aborted. (See #85)

COSCon'19 wants to apply for holding C+L again.

/cc @tedliu1

Thank you for considering!

Mentors

@trivikr
Copy link
Member

trivikr commented Sep 2, 2019

Dates, location and expected number of participants?

@XadillaX
Copy link
Member Author

XadillaX commented Sep 2, 2019

Dates, location and expected number of participants?

sry i forgot to put it.

it's 2-3 Nov.

@tedliu1
Copy link

tedliu1 commented Sep 2, 2019 via email

@tedliu1
Copy link

tedliu1 commented Sep 2, 2019 via email

@XadillaX
Copy link
Member Author

XadillaX commented Sep 3, 2019

/cc @Trott @addaleax

@Trott
Copy link
Member

Trott commented Sep 3, 2019

/cc @Trott @addaleax

I won't be able to travel during that time. Moreover, I've been suggesting a hiatus for Node.js core Code + Learn events, for various reasons. But that doesn't mean that a motivated and knowledgable individual couldn't make a great Code + Learn event happen!

@XadillaX
Copy link
Member Author

XadillaX commented Sep 4, 2019

/cc @Trott @addaleax

I won't be able to travel during that time. Moreover, I've been suggesting a hiatus for Node.js core Code + Learn events, for various reasons. But that doesn't mean that a motivated and knowledgable individual couldn't pull of a great Code + Learn event.

I think I can find some collaborator mentors to join this workshop. But we're lack of experience to hold one C+L workshop. Maybe we want some help of experience.

@yorkie
Copy link

yorkie commented Sep 9, 2019

@oyyd hosted a great workshop at #94, he may give some useful experiences :)

@jizusun
Copy link

jizusun commented Nov 3, 2019

I am going to work on primordials in lib\buffer.js

@peze
Copy link

peze commented Nov 3, 2019

I am going to work on primordials in lib/internal/cluster/worker.js

jizusun added a commit to jizusun/node that referenced this issue Nov 3, 2019
This is my first PR, and it's based on the code-and-learn guidances
This restore some performance after introducing primordialias.

Fixes: nodejs#29766
Refs: nodejs/code-and-learn#97
Refs: nodejs#29633
@PerfectPan
Copy link

I am going to work on var in lib/assert.js

ZYSzys pushed a commit to nodejs/node that referenced this issue Nov 4, 2019
This is my first PR, and it's based on the code-and-learn guidances
This restore some performance after introducing primordialias.

Refs: #29766
Refs: nodejs/code-and-learn#97
Refs: #29633

PR-URL: #30235
Refs: #29766
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
peze added a commit to peze/node-1 that referenced this issue Nov 4, 2019
@peze
Copy link

peze commented Nov 5, 2019

iI am going to work on var in lib/path.js

js00070 added a commit to js00070/node that referenced this issue Nov 5, 2019
replace FIXED_ONE_BYTE_STRING call with env->something_string()
in src/api/environment.cc, src/api/hooks.cc and src/async_wrap.cc

Fixes: nodejs/code-and-learn#97
Refs: nodejs/code-and-learn#97
peze added a commit to peze/node-1 that referenced this issue Nov 6, 2019
targos pushed a commit to nodejs/node that referenced this issue Nov 8, 2019
This is my first PR, and it's based on the code-and-learn guidances
This restore some performance after introducing primordialias.

Refs: #29766
Refs: nodejs/code-and-learn#97
Refs: #29633

PR-URL: #30235
Refs: #29766
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
ZYSzys pushed a commit to nodejs/node that referenced this issue Nov 9, 2019
Refs: nodejs/code-and-learn#97

PR-URL: #30261
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ZYSzys pushed a commit to nodejs/node that referenced this issue Nov 9, 2019
Refs: nodejs/code-and-learn#97

PR-URL: #30246
Refs: nodejs/code-and-learn#97
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to nodejs/node that referenced this issue Nov 9, 2019
PR-URL: #30260
Refs: nodejs/code-and-learn#97
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Nov 10, 2019
This is my first PR, and it's based on the code-and-learn guidances
This restore some performance after introducing primordialias.

Refs: #29766
Refs: nodejs/code-and-learn#97
Refs: #29633

PR-URL: #30235
Refs: #29766
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Nov 10, 2019
This is my first PR, and it's based on the code-and-learn guidances
This restore some performance after introducing primordialias.

Refs: #29766
Refs: nodejs/code-and-learn#97
Refs: #29633

PR-URL: #30235
Refs: #29766
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Nov 11, 2019
This is my first PR, and it's based on the code-and-learn guidances
This restore some performance after introducing primordialias.

Refs: #29766
Refs: nodejs/code-and-learn#97
Refs: #29633

PR-URL: #30235
Refs: #29766
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 17, 2019
Refs: nodejs/code-and-learn#97

PR-URL: #30261
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 17, 2019
Refs: nodejs/code-and-learn#97

PR-URL: #30246
Refs: nodejs/code-and-learn#97
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 17, 2019
PR-URL: #30260
Refs: nodejs/code-and-learn#97
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@antimonyGu
Copy link

antimonyGu commented Nov 17, 2019

I am going to work on primordials in src/events.js

Trott pushed a commit to nodejs/node that referenced this issue Nov 23, 2019
PR-URL: #30577
Refs: nodejs/code-and-learn#97
Refs: #29766
Refs: #29633
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit to nodejs/node that referenced this issue Nov 30, 2019
PR-URL: #30577
Refs: nodejs/code-and-learn#97
Refs: #29766
Refs: #29633
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit to nodejs/node that referenced this issue Dec 1, 2019
Refs: nodejs/code-and-learn#97

PR-URL: #30261
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Dec 1, 2019
Refs: nodejs/code-and-learn#97

PR-URL: #30246
Refs: nodejs/code-and-learn#97
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit to nodejs/node that referenced this issue Dec 1, 2019
PR-URL: #30260
Refs: nodejs/code-and-learn#97
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Dec 1, 2019
PR-URL: #30577
Refs: nodejs/code-and-learn#97
Refs: #29766
Refs: #29633
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Dec 17, 2019
Refs: nodejs/code-and-learn#97

PR-URL: #30261
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Dec 17, 2019
Refs: nodejs/code-and-learn#97

PR-URL: #30246
Refs: nodejs/code-and-learn#97
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit to nodejs/node that referenced this issue Dec 17, 2019
PR-URL: #30260
Refs: nodejs/code-and-learn#97
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Dec 17, 2019
PR-URL: #30577
Refs: nodejs/code-and-learn#97
Refs: #29766
Refs: #29633
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants