feat: use address@2 (#52)

[fengmk2]

Summary by CodeRabbit

• Refactor
  • Removed the 'use strict'; directive across multiple files to streamline JavaScript execution.
• Tests
  • Updated assertion library from power-assert to assert in test files for consistency.
• Documentation
  • Updated the auto-update timestamp in README.md.
• Chores
  • Updated Node.js version support in GitHub workflow files to include newer versions.
• Bug Fixes
  • Changed debugging library in lib/wait-port.js from debug to util.debuglog for improved debugging.
• New Features
  • Updated package dependencies to newer versions in package.json.

[coderabbitai]

Walkthrough

This update streamlines code by removing the 'use strict'; directive across multiple JavaScript files, updates Node.js versions in GitHub Actions, and shifts from using the debug package to util.debuglog for debugging. Changes also include path updates in workflow files and adjustments in package dependencies to better align with newer Node.js versions.

Changes

Files	Change Summary
.eslintrc.js, bin/..., test/...	Removed 'use strict'; directive.
.github/workflows/...	Updated Node.js versions, changed workflow paths.
lib/detect-port.js, lib/wait-port.js	Replaced debug with util.debuglog.
package.json	Updated dependencies and Node.js version requirement.
README.md	Updated auto-update timestamp.

Poem

🐰🌟
In the land of code, where the rabbits roam,
A little hop, a tweak, a streamlined home.
No more strictness in the script, it's free,
Node versions grow like branches of a tree.
A cheer, a leap, for clean and spry flows,
Onwards we hop, to where the green code grows!
🌿🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/address@2.0.2	environment	0	62.3 kB	fengmk2
npm/egg-bin@6.8.1	environment Transitive: eval, filesystem, network, shell, unsafe	+272	56.8 MB	fengmk2
npm/git-contributor@2.1.5	environment, shell Transitive: eval, filesystem, network, unsafe	+85	8.95 MB	xudafeng
npm/mm@3.4.0	network, shell	+7	97.9 kB	fengmk2

🚮 Removed packages: npm/egg-bin@5.18.1, npm/git-contributor@1.1.0, npm/mm@2.5.0, npm/power-assert@1.6.1

View full report↗︎

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/egg-bin@6.8.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

[fengmk2]

@SocketSecurity ignore npm/egg-bin@6.8.1

[coderabbitai]

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9804ad5 and c7c2a3f.

Files selected for processing (11)

• .eslintrc.js (1 hunks)
• .github/workflows/nodejs.yml (1 hunks)
• .github/workflows/release.yml (1 hunks)
• README.md (1 hunks)
• bin/detect-port.js (1 hunks)
• lib/detect-port.js (1 hunks)
• lib/wait-port.js (1 hunks)
• package.json (1 hunks)
• test/cli.test.js (1 hunks)
• test/detect-port.test.js (1 hunks)
• test/wait-port.test.js (1 hunks)

Files skipped from review due to trivial changes (4)

• .eslintrc.js
• bin/detect-port.js
• test/cli.test.js
• test/wait-port.test.js

Additional Context Used

LanguageTool (14)

README.md (14)

Near line 25: Unpaired symbol: ‘]’ seems to be missing
Context: ...tor ## Who are using or has used - ⭐⭐⭐eggjs/egg - ⭐⭐⭐...

---

Near line 26: Unpaired symbol: ‘]’ seems to be missing
Context: ...eggjs/egg](//github.com/eggjs/egg) - ⭐⭐⭐alibaba/ice -...

---

Near line 27: Unpaired symbol: ‘]’ seems to be missing
Context: ...aba/ice](//github.com/alibaba/ice) - ⭐⭐⭐[alibaba/uirecorder](//github.com/alibaba...

---

Near line 28: Unpaired symbol: ‘]’ seems to be missing
Context: ...](//github.com/alibaba/uirecorder) - ⭐⭐⭐[facebook/create-react-app](//github.com/...

---

Near line 29: Unpaired symbol: ‘]’ seems to be missing
Context: ...ages/react-dev-utils/package.json) - ⭐⭐⭐[facebook/flipper](//github.com/facebook/...

---

Near line 30: Unpaired symbol: ‘]’ seems to be missing
Context: ...er](//github.com/facebook/flipper) - ⭐⭐⭐umijs/umi - ⭐⭐⭐...

---

Near line 31: Unpaired symbol: ‘]’ seems to be missing
Context: ...umijs/umi](//github.com/umijs/umi) - ⭐⭐⭐[gatsbyjs/gatsby](//github.com/gatsbyjs/g...

---

Near line 32: Unpaired symbol: ‘]’ seems to be missing
Context: ...sby](//github.com/gatsbyjs/gatsby) - ⭐⭐⭐[electron-react-boilerplate/electron-reac...

---

Near line 33: Unpaired symbol: ‘]’ seems to be missing
Context: ...rplate/electron-react-boilerplate) - ⭐⭐⭐zeit/micro - ⭐...

---

Near line 34: Unpaired symbol: ‘]’ seems to be missing
Context: ...it/micro](//github.com/zeit/micro) - ⭐⭐⭐[rails/webpacker](//github.com/rails/webp...

---

Near line 35: Unpaired symbol: ‘]’ seems to be missing
Context: ...ker](//github.com/rails/webpacker) - ⭐⭐⭐[storybookjs/storybook](//github.com/stor...

---

Near line 103: Unpaired symbol: ‘]’ seems to be missing
Context: ...b>](https://github.com/yavuzakyuz)
|[<img src="https://avatars.githubusercont...

---

Near line 105: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’).
Context: ...//github.com/xudafeng/git-contributor), auto updated at Wed May 08 2024 15:54:54 GMT+0800....

---

Near line 105: Commas set off the year in a month-day-year date.
Context: ...afeng/git-contributor), auto updated at Wed May 08 2024 15:54:54 GMT+0800. <!-- GITCONTR...

Additional comments not posted (8)

.github/workflows/nodejs.yml (1)

15-15: Expansion of Node.js version matrix to include versions 20 and 22 is appropriate.

lib/wait-port.js (1)

1-1: Switch to util.debuglog for debugging aligns with Node.js best practices.

package.json (3)

24-24: Update to address dependency version looks good.

---

28-33: Updates to various development dependencies are noted and appear correct.

---

42-42: Setting the Node.js engine version requirement to >= 14.0.0 is clear and appropriate.

lib/detect-port.js (1)

2-2: Switch to util.debuglog for debugging aligns with Node.js best practices.

README.md (1)

105-105: Update to the auto-update timestamp in the documentation is appropriate.

test/detect-port.test.js (1)

6-6: Switch from power-assert to the standard assert module simplifies the testing framework.

[coderabbitai]

Tip

Codebase Verification

The verification script attempted to confirm the existence of the workflow file at the specified path in the GitHub repository node-modules/github-actions. The script used the GitHub CLI tool (gh) to query the GitHub API for the file .github/workflows/node-release.yml at the branch master. However, the response from the GitHub API indicated that the file could not be found, returning a "Not Found" error with a 404 HTTP status code.

This suggests that the updated workflow path specified in the .github/workflows/release.yml file may be incorrect or the file does not exist at the specified location in the repository. This could potentially lead to failures when the workflow is triggered, as the GitHub Actions runner will not be able to locate the referenced workflow file.

Given this information, it is necessary to flag this issue to ensure it is addressed.

---

Workflow Path Update Issue Detected

The verification process for the updated workflow path in .github/workflows/release.yml has identified an issue. The specified path does not correspond to an existing file in the repository, which could lead to failures during workflow execution. Please review and correct the workflow path.

• File: .github/workflows/release.yml
• Line: 10
• Issue: The specified workflow file node-modules/github-actions/.github/workflows/node-release.yml@master does not exist.

Analysis chain

Update to workflow path looks good.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the new workflow path is valid and accessible.

# Test: Check if the workflow file exists at the specified path.
gh api repos/node-modules/github-actions/contents/.github/workflows/node-release.yml@master

Length of output: 230

[coderabbitai]

Tip

Codebase Verification

The verification script attempted to confirm the existence and accessibility of the GitHub Actions workflow file at the specified path in the repository node-modules/github-actions. The script used the GitHub API to check for the file .github/workflows/node-test.yml at the master branch but received a 404 HTTP error, indicating that the file could not be found.

This suggests that the updated workflow path specified in the .github/workflows/nodejs.yml file might be incorrect or the repository structure has changed, making the path invalid.

Actionable Follow-up

Given the critical nature of CI/CD workflows and the potential impact of an incorrect workflow path, it is essential to address this issue promptly. The development team should verify the correct path to the workflow file and update the .github/workflows/nodejs.yml accordingly.

• Incorrect Workflow Path: The path node-modules/github-actions/.github/workflows/node-test.yml@master does not exist or is not accessible. This needs correction to ensure the CI/CD process functions correctly.

Analysis chain

Update to workflow path looks good.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the new workflow path is valid and accessible.

# Test: Check if the workflow file exists at the specified path.
gh api repos/node-modules/github-actions/contents/.github/workflows/node-test.yml@master

Length of output: 227