Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor with typescript to support esm and cjs both #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

liuhanqu
Copy link

@liuhanqu liuhanqu commented Nov 20, 2023

BREAKING CHANGE: Drop Node.js < 16 support

  1. 使用 ts 重构
  2. 使用 tshy 支持 esm 和 cjs
  3. test 使用 test-runner (这里需要 node v18 版本)

Copy link

socket-security bot commented Nov 20, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
tshy-after 1.0.0 None +0 5.02 kB fengmk2
c8 8.0.1 filesystem, environment +11 520 kB oss-bot
tsx 4.2.0 eval, network, filesystem, shell, environment +1 519 kB
ts-node 10.9.1 filesystem +13 1.39 MB cspotcode
address 2.0.1 environment +0 58.3 kB fengmk2
tshy 1.8.0 filesystem +4 41.4 MB isaacs
git-contributor 1.1.0...2.1.5 network +22/-41 2.74 MB xudafeng
eslint-config-egg 12.3.1...13.0.0 None +9/-11 4.72 MB fengmk2

🚮 Removed packages: command-line-test@1.0.10, mm@2.5.0, pedding@1.1.0, power-assert@1.6.1

@fengmk2 fengmk2 self-requested a review November 20, 2023 12:30
@fengmk2 fengmk2 self-assigned this Nov 20, 2023
@fengmk2
Copy link
Member

fengmk2 commented Nov 20, 2023

https://github.com/node-modules/detect-port/blob/master/.github/workflows/nodejs.yml#L18 这里去掉 14,加上 20 的测试环境

@liuhanqu
Copy link
Author

想问下 waitPort 方法的使用场景是什么?
看了代码,没太 get 到

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants